Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Textarea #559

Closed
wants to merge 1 commit into from
Closed

Textarea #559

wants to merge 1 commit into from

Conversation

EnoF
Copy link
Contributor

@EnoF EnoF commented Nov 7, 2014

Added a new option to mdTextFloat to accept a new type textarea. This will create an mdTextInput with an textarea rather than an input.

Example:

<md-text-float label="intro"    ng-model="user.intro" type="textarea" ></md-text-float>

Follup up from: #534

@marcysutton
Copy link
Contributor

Can you try to avoid committing whitespace changes if possible? It makes the pull request a lot bigger than it has to be. Thank you!

@EnoF
Copy link
Contributor Author

EnoF commented Nov 7, 2014

@marcysutton I reverted the changes on the white spaces and replaced the commit.

@bglowacki
Copy link

Is there any chance to merge it?

@EnoF EnoF force-pushed the textarea branch 2 times, most recently from dbdac95 to a9b269d Compare November 18, 2014 13:51
@EnoF
Copy link
Contributor Author

EnoF commented Nov 18, 2014

I've rebased my branch with the latest master.

@ThomasBurleson
Copy link
Contributor

@EnoF - more than likely, these changes will not be merged into the 0.6.0 release.

Several other issues have been submitted regarding <md-text-float>. Most of those are a result of many custom attributes have not been applied directly to the nested . Once that enhancement has been resolved, then this feature will be merged.

@ThomasBurleson ThomasBurleson added this to the 0.7.0-rc1 milestone Nov 18, 2014
@EnoF
Copy link
Contributor Author

EnoF commented Nov 18, 2014

Thanks for the update. I'll just regularly rebase it to avoid a merge party in the end :)

@ThomasBurleson
Copy link
Contributor

@EnoF - Excellent. We will notify you when ready to merge. Thank you for your contribution(s).

@googlebot
Copy link

CLAs look good, thanks!

@abodacs
Copy link

abodacs commented Dec 28, 2014

Is there any chance to merge it soon?

```
<md-text-float rows="4" cols="50"
                            type="textarea"
                            label="{{labels.intro}}"
                            ng-model="user.intro">
 ```
@lcotonea
Copy link

lcotonea commented Jan 5, 2015

Is there a chance that the 0.7.0 release will embed this feature?

@ajoslin
Copy link
Contributor

ajoslin commented Jan 8, 2015

Textarea added via 60fcd6f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants