This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
WIP: Make bottom sheet items accessible #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
added
a11y
|
@marcysutton - can you provide some unit tests that conform/validate these recent changes? |
|
@ThomasBurleson sure thing! They were markup-only changes, so I'll explore the best way to test. |
marcysutton
changed the title
|
@ThomasBurleson made the bottom sheets use buttons awhile ago. I added aria-labels, and it looks good now. @marcysutton can you confirm with the above commit that all is well? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the accessibility improvements to
<md-bottom-sheet>, this PR includes changes to the markup that make nested items into real interactive controls.Known issue regarding focus management: #571