fix(textarea): fix textarea grow

[devversion]

Fixes Textarea Input

Fixes #5751

[devversion]

@ThomasBurleson @EladBezalel
I created another commit (not squashed yet - by intention - ability to revert), which contains min-rows (Minimum Rows), rows (Fixed Rows) and unspecified (starting at 1).

Can you please review that commit and give me a suggestion about adding the min-rows attribute. Should we use another attribute name?

[morriq]

Working well on my website. 👍

[devversion]

Update

• Added complicated tests for min-rows, rows and unspecified rows attribute
• Fixed Minimum Rows if text content is exactly at minimum

PS: @EladBezalel Can you please take a look 😄 + (not yet squashed)

[EladBezalel]

layout-padding is making the text areas look weird, wrap them with divs or make a class

[devversion]

I just copied that from the Basic Demo, or is this a difference because of the other inputs?

[topherfangio]

The CSS for layout-padding changed recently. We are aware of some issues with it, but the quick workaround is to wrap the content in a <div>.

[devversion]

The most of your suggestions are now ready. @EladBezalel

[morriq]

Seems there is problem with this PR.

sorry for no codepen or something. I don't know how to include changed library to sourcecode.

It's removing default value if exists.

<md-input-container ng-init="test = '123';">
<textarea ng-model="test"></textarea>
</md-input-container>

[morriq]

this line causing problems(It's removing default value if exists.)

[devversion]

All problems are now solved @morriq
Thanks for keeping an eye on that :)

PS: Ignore Travis CI -> It's currently always failing due an error in websockets/ws

[EladBezalel]

i'd expect a variable to save the height into and applying node.style.height = only once for more readability

[EladBezalel]

Hey @devversion, because we're past 1.0 we try our best not to introduce breaking changes.
We should make this PR without any breaking API, if you will need my help ping me.

It's also fixing #5919 ?

[devversion]

@EladBezalel Just thought a bit about the breaking change. I don't think it such a huge breaking change, it's just adding the attribute min-rows to allow growing rows.

Little Explanation:

• rows="5" - Fixed 5 Rows
• min-rows="5" - Minimum 5 Rows (can grow)

I think it's not a big change, and I think it also needed to provide this new attribute to allow the users to decide how the <textarea> should behave. Let me know what you think? And what are you thinking @ThomasBurleson?

PS: And yes - this should fix #5919 too, and please take a look at the new <textarea> demos from the PR 😄

[EladBezalel]

@ThomasBurleson assigned to you not because it's ready, please review.

[alexthewilde]

+1

[EladBezalel]

As this is not the complete and desired behavior of textarea, im closing this one,
@crisbeto can you please open an issue about our new documented textarea and note there our concerns and wanted behavior?