fix(progressCircular): fixes scaling issues #5891
Conversation
robertmesserle
added
the
needs: review
| height: (100 * getDiameterRatio()) + 'px' | ||
| }); | ||
| circle.children().eq(0).css(toVendorCSS({ | ||
| transform : $mdUtil.supplant('translate(-50%, -50%) scale( {0} )',[getDiameterRatio()]) |
There was a problem hiding this comment.
@robertmesserle - is the translate( ) fixed regardless of the scale value ?
There was a problem hiding this comment.
Yea, it's a percentage-based translate, so it will center the spinner.
There was a problem hiding this comment.
this line could use an explanation of its intent.
| @@ -74,7 +75,7 @@ md-progress-circular { | |||
| } | |||
|
|
|||
|
|
|||
| .md-spinner-wrapper.md-mode-indeterminate { | |||
| .md-mode-indeterminate .md-spinner-wrapper { | |||
There was a problem hiding this comment.
Just curious, was there a reason why these were swapped?
There was a problem hiding this comment.
The DOM structure had to change to make this happen. I added an extra container that could be scaled separate from the outer container.
There was a problem hiding this comment.
Ah gotcha! I missed the space between them or I wouldn't have asked (I thought you literally just swapped the order of the selector 😄).
|
LGTM (assuming tests pass 😄) |
ThomasBurleson
added
pr: merge ready
|
@robertmesserle - CI tests are failing. |
ThomasBurleson
added
needs: tests
and removed
pr: merge ready
robertmesserle
force-pushed
the
issues/4839
branch
2 times, most recently
from
50af5b0
to
144d36d
Compare
robertmesserle
added
needs: review
ThomasBurleson
added
needs: rebase
|
@robertmesserle - please rebase. |
robertmesserle
force-pushed
the
issues/4839
branch
from
144d36d
to
5db570e
Compare
|
@ThomasBurleson Done |
Closes #4839
@ThomasBurleson @jelbourn @topherfangio