This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(toast): add missing a11y context. See #349 #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -213,7 +213,9 @@ function MdToastProvider($$interimElementProvider) { | |||
| var opts = { | |||
| template: [ | |||
| '<md-toast md-theme="{{ toast.theme }}" ng-class="{\'md-capsule\': toast.capsule}">', | |||
| '<span flex>{{ toast.content }}</span>', | |||
| '<span flex role="alert" aria-relevant="all" aria-atomic="true">' + | |||
There was a problem hiding this comment.
This won't actually work, because the Toast is inserted and then removed–ARIA Live Regions have to be present at load time and remain in the page to be picked up by screen readers. We talked a while back about creating a global messaging directive for this purpose–could that be incorporated here? #3174
There was a problem hiding this comment.
My testing showed that this worked with NVDA on Firefox and VoiceOver with Safari.
There was a problem hiding this comment.
That's good, there is some support then! I did find the toasts were not announced in JAWS with IE or Chrome and Voiceover. JAWS would be more important, while Chrome isn't used with VO as much as Safari.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcysutton