This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(toast): Hide scrollbars during animation. #6029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertmesserle My other method of preventing toast scrollbars already got merged, but I have created a new PR with your suggestion of using a wrapper div with |
topherfangio
added
in progress
|
Spoke with Thomas offline and he suggested a few changes. Implementing them now. |
During animation, certain browsers would show scroll bars if the toast was positioned at the bottom of the parent container. Fix by wrapping the animated portions in a div with hidden overflow. Also, update documentation with notes about positioning and recommendations. BREAKING CHANGE md-toast now applies the enter/leave animations to an inner div with a class `md-toast-content`. If you have customized the animations or other styles of your toast, you will need to update your CSS to account for the new wrapper. Fixes #2936.
topherfangio
force-pushed
the
team/topher/fix-toast-scrolling-2936
branch
from
aa1b630
to
258f158
Compare
topherfangio
removed
in progress
|
@ThomasBurleson @robertmesserle Finished the requested changes. Can you please review? |
|
LGTM |
topherfangio
added
pr: merge ready
|
@jelbourn - I want to include this in the v1.0.0 build. Thoughts? |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During animation, certain browsers would show scroll bars if the
toast was positioned at the bottom of the parent container.
Fix by wrapping the animated portions in a div with hidden
overflow.
Also, update documentation with notes about positioning and
recommendations.
BREAKING CHANGE
md-toast now applies the enter/leave animations to a wrapper
div with a class
md-toast-wrapper. If you have customizedthe animations or other styles of your toast, you will need
to update your CSS to account for the new wrapper.
Better fix for #2936.