This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): always set tabindex to allow receiving focus. #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (attr.hasOwnProperty('tabindex')) { | ||
| element.attr('tabindex', '-1'); | ||
| } | ||
| element.attr('tabindex', '-1'); |
There was a problem hiding this comment.
It looks like someone originally went to do the right thing and forgot a !. It should be:
if (!attrs['tabindex']) {
$element.attr('tabindex', '-1');
}
devversion
force-pushed
the
fix/autocomplete-receive-focus
branch
2 times, most recently
from
94ebebb
to
f8fcbb2
Compare
| @@ -98,6 +98,31 @@ describe('<md-autocomplete>', function() { | |||
| element.remove(); | |||
| })); | |||
|
|
|||
| it('should allow receiving focus on the autocomplete', function() { | |||
| var scope = createScope(null, {inputId: 'custom-input-id'}); | |||
| var template = '\ | |||
There was a problem hiding this comment.
Prefer string concatenation instead of using \
There was a problem hiding this comment.
I'm just trying my best in using the best code conventions. The tests above also use \.
But I will use string concatenation, because you wish that 😄
There was a problem hiding this comment.
Yeah- typically good, but I've been hoping to eliminate the \ stuff over time.
There was a problem hiding this comment.
Great, I will remember that
devversion
force-pushed
the
fix/autocomplete-receive-focus
branch
from
f8fcbb2
to
825cd9c
Compare
|
Used your suggestions now @jelbourn |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we only set the
tabindexif we specify atabindexattribute.That's why the autocomplete won't receive focus on
sidenavautofocus.Closes #6101 Fixes #5665
Please review @jelbourn