Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(button): fixes md-fab icon position with href attribute #646

Closed
wants to merge 1 commit into from

Conversation

robertmesserle
Copy link
Contributor

This is related to issue #591

@marcysutton
Copy link
Contributor

I think we need to update our docs examples to show the different md-button options. They still show <md-button>, even though you can use the class directly on a native element. I want to believe people won't try to put an href on <button class="md-button">, but I'm not convinced. Anchor vs. button affects how people will interact with keyboards and screen readers, so it's important to make the distinction.

Updated Plunkr showing an anchor tag with href: http://plnkr.co/edit/np1n4JicBQEc2EuAgDQj

@ThomasBurleson
Copy link
Contributor

Great idea. +1

On Friday, November 14, 2014, Marcy Sutton notifications@github.com wrote:

I think we need to update our docs examples to show the different
md-button options. They still show , even though you can use
the class directly on a native element. I want to believe people won't try
to put an href on , but I'm not convinced.
Anchor vs. button affects how people will interact with keyboards and
screen readers, so it's important to make the distinction.

Updated Plunkr showing an anchor tag with href:
http://plnkr.co/edit/np1n4JicBQEc2EuAgDQj


Reply to this email directly or view it on GitHub
#646 (comment).

Thomas Burleson
Mindspace LLC

http://www.gridlinked.info
http://www.linkedin/in/ThomasBurleson
https://github.com/ThomasBurleson

@marcysutton marcysutton deleted the fix-fab-with-href branch November 18, 2014 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants