This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): fix dynamic height demo for tabs #6785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was introduced in d860274. Because of the new `svg-asset-cache` script, we need to init the module ourself. The tabs demo was always working, because the `asset cache` initialized the module (unintentional). Fixes angular#6780
devversion
force-pushed
the
fix/tabs-demo1-ngapp
branch
from
93fc3c2 to
336d3ae
Compare
|
@devversion - good catch. |
ThomasBurleson
added
the
pr: merge ready
|
BTW - this does NOT fix #6780. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced in d860274.
Because of the new
svg-asset-cachescript, we need to init the module ourself.The tabs demo was always working, because the
asset cacheinitialized the module (unintentional).Fixes #6780