-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(tooltip): add configurable tooltip delay #713
Conversation
add md-tooltip-delay attribute binding to accommodate a variable show delay
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Not sure what to do about the @googlebot message above. I have signed the CLA. |
Looks like you authored the commit with another name and email address than what is registered with Github. Check your .gitconfig file in your home dir. It may need to have |
@jpdesigndev can you change the email as @Splaktar suggested so we can merge this? |
Sure thing. I'll just have to figure out how to do so. edit Figured it out. Coming right up. |
add md-tooltip-delay attribute binding to accommodate a variable show delay
@ajoslin Let me know if this works for you. Otherwise, I suppose I can create a clean PR. Thanks :) |
Looks like the CLA bot is happy now. |
Yes! I simply completed the original commit with work email or something weird. Anyways, I'd, of course, love for this to make it into the next release :) |
Could you also add a quick documentation line for this feature? If I'm not mistaken, it should be added here. |
@PaulMougel Done. Dunno if you want the param defaults thing |
I don't understand what's going on with the CLA bot on the last commit. I am the author of that commit Here's the commit on my repo. |
Added a unit test and merged! Thanks. |
@ajoslin Awesome! Your welcome, and thank you. |
@ajoslin: Are you sure the tests passed with your commit ? From looking at it, it seems incorrect. |
@gkalpak In the first commit, I had some changes that I accidentally did not amend into the commit before I pushed. I subsequently force pushed with the second commit, which does work correctly. |
Great ! |
Currently, there is no way to configure the tooltip delay timeout. This provides a basic attribute,
md-tooltip-delay
for doing so. Granted, this could be better following some discussion on how you feel about rolling in a config provider into the directive.