Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(list): secondary item container expected a height of 100% #8137

Closed

Conversation

devversion
Copy link
Member

  • The height of 100% for the secondary item container was depending on its parent DOM structure. So in some weird cases, the secondary item container was reserving 100% height of the screen.

This property even became unnecessary, because now the secondary items are expecting its size correctly and will fill the remaining space by the auto margin.

Thoroughly tested the List Demo, Divider Demo and a few User-specified list layouts.

Fixes #8094.

* The height of 100% for the secondary item container was depending on its parent DOM structure. So in some weird cases, the secondary item container was reserving 100% height of the screen.

Fixes angular#8094.
@devversion devversion added the needs: review This PR is waiting on review from the team label Apr 20, 2016
@scriptsure
Copy link

i think this is exactly issue i am currently having in my main body:

`

<ui-view name="main-nav"></ui-view>
<ui-view flex layout-fill layout="column" name="content" ></ui-view>
`

The main-nav is just a md-toolbar... and the content is everything below the main navigation. what is happening is that the layout-fill on the content is trying to use 100%. Once computed of course the height equals the same height of the BODY. Thus, we get a scrollbar in the browser!

is this fix going to be committed soon?

Thanks

@devversion
Copy link
Member Author

Fix combined into #8075

@devversion devversion closed this May 30, 2016
@devversion devversion deleted the fix/list-webkit-stretching branch May 30, 2016 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants