This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(menu-item): properly compile when used with ng-repeat #8852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
changed the title
crisbeto
force-pushed
the
8697/menu-repeat
branch
from
ae73459 to
756d583
Compare
| setDefault('role', (templateAttrs.type == 'checkbox') ? 'menuitemcheckbox' : 'menuitemradio', buttonEl); | ||
| angular.forEach(['ng-disabled'], moveAttrToButton); | ||
| setDefault('role', type == 'checkbox' ? 'menuitemcheckbox' : 'menuitemradio', buttonEl); | ||
| moveAttrToButton('ng-disabled'); |
There was a problem hiding this comment.
This function should be updated to use the prefixer.
To check if the attribute (with all prefixes) is present on the element.
$mdUtil.prefixer().hasAttribute(element, 'ng-disabled');There was a problem hiding this comment.
Sorry I was not clear.
I mean, that we should also move prefixed attributes.
function moveAttrToButton(attribute) {
var attributes = $mdUtil.prefixer(attribute);
attributes.forEach(function(attr) {
if (templateEl.hasAttribute(attr) {
button[0].setAttribute(attr, val);
templateEl[0].removeAttribute(attr);
}
}
crisbeto
force-pushed
the
8697/menu-repeat
branch
from
756d583 to
3206a22
Compare
| @@ -20,10 +23,11 @@ function MenuItemDirective($mdUtil) { | |||
| templateEl.html(''); | |||
| templateEl.append(angular.element('<md-icon md-svg-icon="check"></md-icon>')); | |||
| templateEl.append(buttonEl); | |||
| templateEl[0].classList.add('md-indent'); | |||
| templateEl.addClass('md-indent'); | |||
| templateAttrs.$set('mdInMenuBar', null); | |||
There was a problem hiding this comment.
I think you forgot to change that - it should remove the class.
There was a problem hiding this comment.
Ops, thanks. Good catch.
crisbeto
force-pushed
the
8697/menu-repeat
branch
2 times, most recently
from
8ec3fd5 to
1e15366
Compare
* Fixes the menuItem directive not compiling properly when used together with ngRepeat. This is due to the fact that ngRepeat passes around a documentFragment, instead of a DOM node, which means that it doesn't have a parent and doesn't allow us to properly determine whether the menuItem is inside of a menuBar. This change switches the behavior by making the menuBar directive mark it's children instead. * Minor cleanup in the menuItem directive. * Avoided some repetition in the menuBar unit tests. * Switches to using the prefixer in the menuItem directive. Referencing angular#8117. Fixes angular#8697.
crisbeto
force-pushed
the
8697/menu-repeat
branch
from
1e15366 to
d0a51b5
Compare
|
@ThomasBurleson Looks good to me ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #8117.
Fixes #8697.