-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove $mdMedia references from mdDialog example #9032
Conversation
cleanup $mdMedia references in example. fullscreen only applies when the screen is xs and sm even when set to true. See also angular#5924
clickOutsideToClose:true, | ||
fullscreen: useFullScreen | ||
clickOutsideToClose: true, | ||
fullscreen: true // Fullscreen only applies for -xs, -sm breakpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Just rethought again. We don't want to force the users on -xs, -sm breakpoints to always use the Fullscreen Dialog.
Those should be able to toggle that functionality within the checkbox
in the demo HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! There are several other dialogs in this example that don't use fullscreen. My personal opinion is that they were sufficient to show what mdDialog is about without fullscreen. But I'll make that change.
I'm trying to change the index.html |
@SpikesCafe-google Cool thanks. While you're at it, can you probably set the default fullscreen value to |
This PR looks good to me. Thanks |
Thanks! I wanted to update the HTML to clarify a little and not hide the checkbox (a little too tricky for an example), but I'm not familiar enough with github to do it. Something like this after the prerendered checkbox:
As a replacement for the old fullscreen checkbox. |
I like the idea. Can't you try to edit the file here? |
It says I must be on a branch to make or propose changes to this file. |
@SpikesCafe-google Ah gotcha. Here is a reference to your branch. |
cleanup $mdMedia references in example. fullscreen only applies when the screen is xs and sm even when set to true.
See also #5924