Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Remove $mdMedia references from mdDialog example #9032

Closed
wants to merge 5 commits into from

Conversation

SpikesCafe-google
Copy link
Contributor

cleanup $mdMedia references in example. fullscreen only applies when the screen is xs and sm even when set to true.

See also #5924

cleanup $mdMedia references in example. fullscreen only applies when the screen is xs and sm even when set to true.

See also angular#5924
clickOutsideToClose:true,
fullscreen: useFullScreen
clickOutsideToClose: true,
fullscreen: true // Fullscreen only applies for -xs, -sm breakpoints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Just rethought again. We don't want to force the users on -xs, -sm breakpoints to always use the Fullscreen Dialog.

Those should be able to toggle that functionality within the checkbox in the demo HTML.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! There are several other dialogs in this example that don't use fullscreen. My personal opinion is that they were sufficient to show what mdDialog is about without fullscreen. But I'll make that change.

@jelbourn jelbourn added the g3: pr This PR was posted by an internal or external product team. label Jul 14, 2016
@devversion devversion added the needs: review This PR is waiting on review from the team label Jul 14, 2016
@SpikesCafe-google
Copy link
Contributor Author

I'm trying to change the index.html

@devversion
Copy link
Member

@SpikesCafe-google Cool thanks. While you're at it, can you probably set the default fullscreen value to false?

@devversion
Copy link
Member

This PR looks good to me. Thanks

@SpikesCafe-google
Copy link
Contributor Author

Thanks! I wanted to update the HTML to clarify a little and not hide the checkbox (a little too tricky for an example), but I'm not familiar enough with github to do it. Something like this after the prerendered checkbox:

<md-checkbox ng-model="customFullscreen" aria-label="Fullscreen Custom Dialog">Use full screen mode for custom dialog</md-checkbox>
<p class="md-caption">Allows the dialog to consume all available space on small devices</p>

As a replacement for the old fullscreen checkbox.

@devversion
Copy link
Member

@SpikesCafe-google
Copy link
Contributor Author

It says I must be on a branch to make or propose changes to this file.

@devversion
Copy link
Member

@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Jul 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
g3: pr This PR was posted by an internal or external product team. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants