This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): do not wrap proxied element when using ng-click #9191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently when using a proxied element (like `md-checkbox`) as a secondary item and having the `ng-click` attribute on it, the list is wrapping the proxied element inside of an button. This isn't valid, because the proxied elements are already clickable. * Proxied Elements are still not used as proxies for the list, when they use `ng-click` on it. Fixes angular#6152.
Contributor
|
@devversion - good to know. |
Member
Author
|
Will be addressed with #9194 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-checkbox) as a secondary item and having theng-clickattribute on it, the list is wrapping the proxied element inside of an button.This isn't valid, because the proxied elements are already clickable.
ng-clickon it.@ThomasBurleson
Fixes #6152.