This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(radio-group): wrong aria-checked value on load when used with ng-value #9790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
a11y
ThomasBurleson
added
needs: presubmit
and removed
needs: review
jelbourn
reviewed
Oct 21, 2016
| element.addClass(CHECKED_CSS); | ||
| if (element[0].parentNode.nodeName.toLowerCase() !== 'md-radio-group') { | ||
| // If the radioButton is inside a div, then add class so highlighting will work | ||
| elemet.parent().toggleClass(CHECKED_CSS, checked); |
There was a problem hiding this comment.
Typo: elemet. Google presubmit caught this.
|
@crisbeto - ping regard |
…value * Fixes all of the radio buttons within a radio group having `aria-checked` set to true on load, when using `ng-value`. * Cleans up the `radioButton` directive. Fixes angular#9400.
crisbeto
force-pushed
the
9400/radio-group-checked
branch
from
0eb8bb8 to
f25ef92
Compare
|
Fixed @ThomasBurleson @jelbourn. We should really get that linter set up... |
|
@crisbeto - sgtm. Btw - I missed the spelling issue myself while reviewing the code. |
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-checkedset to true on load, when usingng-value.radioButtondirective.Fixes #9400.