fix(tabs): selectedIndex being overwritten if tabs are being added / removed #12245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
googlebot
added
the
cla: yes
devversion
changed the title
devversion
force-pushed
the
fix/tabs-selected-index-overwritten
branch
2 times, most recently
from
da0d714 to
e087141
Compare
crisbeto
reviewed
Jul 17, 2018
src/lib/tabs/tab-group.ts
Outdated
| // (since Math.max(NaN, 0) === NaN). | ||
| let indexToSelect = this._indexToSelect = | ||
| Math.min(this._tabs.length - 1, Math.max(this._indexToSelect || 0, 0)); | ||
| // Clamp the `indexToSelect` not immediately in the setter because it can happen that |
There was a problem hiding this comment.
"Don't clamp the indexToSelect immediately in the setter..."
src/lib/tabs/tab-group.ts
Outdated
| // Note the `|| 0`, which ensures that values like NaN can't get through | ||
| // and which would otherwise throw the component into an infinite loop | ||
| // (since Math.max(NaN, 0) === NaN). | ||
| return Math.min(this._tabs.length - 1, Math.max(this._indexToSelect || 0, 0)); |
There was a problem hiding this comment.
This function feels a little weird since it's taking the _indexToSelect from this, but then it's just returning it instead of reassigning. Changing it to a parameter would be clearer and would allow it to be used for other things:
private _clampIndex(index: number): number {
return Math.min(this._tabs.length - 1, Math.max(index || 0, 0));
}There was a problem hiding this comment.
I agree with that.
Note: I allowed number | null as parameter type because I wanted to keep that NaN comment somewhere. Otherwise we would need to fallback multiple times to || 0.
crisbeto
added
pr: lgtm
action: merge
…removed Due to a recent change that ensures that the selected tab will be kept selected if a new tab has been added or removed (angular#9132), updating the `selectedIndex` at the same time will not have any effect because it will be overwritten by the `_tabs.change` (from angular#9132). In order to guarantee that developers can add new tabs and immediately select them once the change detection runs, we only re-index the `selectedIndex` (purpose of angular#9132) whenever the `indexToSelect` has not explicitly changed (through developer bindings for example) Fixes angular#12038
devversion
force-pushed
the
fix/tabs-selected-index-overwritten
branch
from
4a140b5 to
f73f459
Compare
josephperrott
pushed a commit
that referenced
this pull request
Jul 20, 2018
josephperrott
pushed a commit
that referenced
this pull request
Jul 20, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent change that ensures that the selected tab will be kept selected if a new tab has been added or removed (#9132), updating the
selectedIndexat the same time will not have any effect because it will be overwritten by the_tabs.change(from #9132).In order to guarantee that developers can add new tabs and immediately select them once the change detection runs, we only re-index the
selectedIndex(purpose of #9132) whenever theindexToSelecthas not explicitly changed (through developer bindings for example)Fixes #12038