Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): pointing to non-existent element via aria-labelledby #12411

Merged
merged 1 commit into from
Aug 27, 2018
Merged

fix(select): pointing to non-existent element via aria-labelledby #12411

merged 1 commit into from
Aug 27, 2018

Conversation

crisbeto
Copy link
Member

Fixes mat-select referring to an element that doesn't exist, through aria-labelledby, if the select is inside a form field that doesn't have a label.

Fixes #12405.

@crisbeto
fix(select): pointing to non-existent element via aria-labelledby
eaaf0f0 
Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes angular#12405.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jul 27, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2018
jelbourn
jelbourn approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 27, 2018
@jelbourn jelbourn merged commit 3b7f0f1 into angular:master Aug 27, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
@crisbeto @jelbourn
fix(select): pointing to non-existent element via aria-labelledby (#1…
12c6f81 
…2411)

Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes #12405.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a11y: mat-select components can create aria-labelledby attributes with invalid values
3 participants
@crisbeto @jelbourn @googlebot