Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker-toggle): forward tabindex to underlying button #12461

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

crisbeto
Copy link
Member

Forwards the tabindex of a mat-button-toggle to its underlying button and clears it from the host element.

Fixes #12456.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 31, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner July 31, 2018 16:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 31, 2018
@crisbeto crisbeto force-pushed the 12456/datepicker-toggle-tabindex branch 2 times, most recently from ac6f162 to 1e78e47 Compare August 5, 2018 14:34
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes angular#12456.
@crisbeto crisbeto force-pushed the 12456/datepicker-toggle-tabindex branch from 1e78e47 to a3e36fd Compare August 12, 2018 11:34
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 23, 2018
@ngbot
Copy link

ngbot bot commented Aug 23, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added the Accessibility This issue is related to accessibility (a11y) label Aug 24, 2018
@jelbourn jelbourn merged commit 648eb4a into angular:master Aug 24, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes #12456.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tabindex on MatDatepickerToggle
4 participants