fix(ng-update): do not throw if imports without named bindings are used #12866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if someone uses a namespace import or an import without named bindings in an Angular application, the `ng-update` schematics from Angular Material will fail due to missing safety checks before casting. Fixes angular#11571
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
devversion
commented
Aug 28, 2018
| return; | ||
| } | ||
|
|
||
| const namedBindings = node.importClause.namedBindings; |
There was a problem hiding this comment.
Note: Storing the namedBindings here because future "import misc" cases will also always depend on the named bindings.
jelbourn
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 5, 2018
…ed (angular#12866) Currently if someone uses a namespace import or an import without named bindings in an Angular application, the `ng-update` schematics from Angular Material will fail due to missing safety checks before casting. Fixes angular#11571
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if someone uses a namespace import or an import without named bindings in an Angular application, the
ng-updateschematics from Angular Material will fail due to missing safety checks before casting.Fixes #11571