-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/expansion): panel appearing as open when parent is animating away #11778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a019463
to
39ddff9
Compare
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
2 similar comments
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
39ddff9
to
53341e5
Compare
53341e5
to
fb72c01
Compare
fb72c01
to
0b2dde5
Compare
@crisbeto Been spending all afternoon playing around and trying to understand this issue. Adding a class of Even if my slide animation on the 'outside' has an explicit css class and What I'm really having a difficult time understanding is why all the controls inside accordion are able to inherit This is most frustrating because you think animating a panel off screen will take about 15 minutes to do and then everything exploded in my face (literally!!) |
Please Solve this Issue ASAP. |
0b2dde5
to
639b3c2
Compare
Rebased and bumping to a P2, because the issue keeps getting reported. |
I think there is an unintended side-effect of this change. If your expansion panel starts as You can see this if you change the demo's expansion panel to be
|
any news on that conflict? |
…ting away Fixes an issue where the expansion panel will appear as if it is open, if the element is part of a component that is animating away. The issue comes from the fact that Angular resets the animation state to `void` which we don't have in the animation definitions. Fixes angular#11765.
639b3c2
to
16fe90e
Compare
Seeing that this is still not merged I have found another workaround.
Notice that I added a "void" state and transition. It is duplicate code, but other than that I did not encounter any issues with it. |
Closing in favor of #30119. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes an issue where the expansion panel will appear as if it is open, if the element is part of a component that is animating away. The issue comes from the fact that Angular resets the animation state to
void
which we don't have in the animation definitions.Fixes #11765.