This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Selected song after removing an album from the playlist #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't continue to play the last played song after removing it from the playlist. * Added a test to ensure this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I found a small problem in your otherwise very nice application.
Steps to replicate:
What is played now is still the song that has been playing when the album was removed from the playlist instead of the currently selected song.
I added the tiny fix needed to make this working and the corresponding test case. It might be even more concise to have a
player.stoppedvariable to handle this, but I think this is sufficient for now.With kind regards,
Marc