Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
chore(release): update selenium-webdriverjs and bump version number (#…
Browse files Browse the repository at this point in the history
…4538)

1.Update selenium-webdriverjs and bump version number
2.Solve compatibility problem: new webdriver has a more strict method
when setting script timeout. If no script timeout was specified, set timeout to 0.
  • Loading branch information
qiyigg authored and vikerman committed Oct 13, 2017
1 parent 862e8be commit 0fbc2c0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion lib/runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,8 @@ export class Runner extends EventEmitter {
return browser_.waitForAngularEnabled(initProperties.waitForAngularEnabled);
})
.then(() => {
return driver.manage().timeouts().setScriptTimeout(initProperties.allScriptsTimeout);
return driver.manage().timeouts().setScriptTimeout(
initProperties.allScriptsTimeout || 0);
})
.then(() => {
return browser_;
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"optimist": "~0.6.0",
"q": "1.4.1",
"saucelabs": "~1.3.0",
"selenium-webdriver": "3.0.1",
"selenium-webdriver": "3.6.0",
"source-map-support": "~0.4.0",
"webdriver-js-extender": "^1.0.0",
"webdriver-manager": "^12.0.6"
Expand Down Expand Up @@ -81,5 +81,5 @@
"engines": {
"node": ">=6.9.x"

This comment has been minimized.

Copy link
@zerdos

zerdos Oct 18, 2017

<8

},
"version": "5.1.2"
"version": "5.2.0"
}

0 comments on commit 0fbc2c0

Please sign in to comment.