Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
feat(saucelabs): Add Sauce Labs HTTPS Support (#4071)
Browse files Browse the repository at this point in the history
  • Loading branch information
@KevinMarkVI @heathkit
KevinMarkVI authored and heathkit committed Feb 7, 2017
1 parent 29f975a commit 3edd62e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/driverProviders/sauce.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ export class Sauce extends DriverProvider {
this.config_.capabilities['username'] = this.config_.sauceUser;
this.config_.capabilities['accessKey'] = this.config_.sauceKey;
this.config_.capabilities['build'] = this.config_.sauceBuild;
let auth = 'http://' + this.config_.sauceUser + ':' + this.config_.sauceKey + '@';
let auth = 'https://' + this.config_.sauceUser + ':' + this.config_.sauceKey + '@';

This comment has been minimized.

Sign in to view

Copy link
@DOrlov77

DOrlov77 May 8, 2017

Missed usage of config.sauceSeleniumUseHttp parameter!
Current fix should be called "Use HTTPS ONLY" instead of "Add Sauce Labs HTTPS Support". :)
That cause some bugs using plugg-ins such "sauce-connect-launcher".

This comment has been minimized.

Sign in to view

Copy link
@heathkit

heathkit May 8, 2017 •
edited
Loading

Contributor

Thanks, this has already been fixed. The fix will be picked up in the 5.1.2 release tomorrow. Good catch, though!
this.config_.seleniumAddress =
auth + (this.config_.sauceSeleniumAddress ? this.config_.sauceSeleniumAddress :
'ondemand.saucelabs.com:80/wd/hub');
'ondemand.saucelabs.com:443/wd/hub');

// Append filename to capabilities.name so that it's easier to identify
// tests.
Expand Down

0 comments on commit 3edd62e

Please sign in to comment.