This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(webdriver-manager): minor proxy enhancements
Added error handling for request - previously, any errors coming from the request module were silently swallowed. Fixed error handling to remove empty files when a download fails for some reason. Instead of throwing an error as an exception, the error is simply logged and then the rest of the code continues. Previously, the uncaught exceptions caused the program to stop immediately, without any chance of recovering, or finishing other downloads. With the previous code, any other downloads at the same time were interrupted, resulting in empty files or incomplete downloads. Logging the errors instead of throwing will allow the other downloads to finish, and it will also allow removing empty files resulting from a failed download, e.g. when no internet connection is available or with an invalid proxy configuration. Also evaluating both uppercase and lowercase proxy variables. Many tools use proxy variables in the form https_proxy, others use HTTPS_PROXY. I changed the code so both forms are evaluated. See the following links for more info on this practice: * http://serverfault.com/q/571887/140074 * https://wiki.archlinux.org/index.php/proxy_settings#Environment_variables
- Loading branch information