Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
chore(dependencies): update selenium-webdriver to 2.47.1
Browse files Browse the repository at this point in the history
Along with it, update `jasminewd2` to avoid situations where the
control flow gets locked up and hangs.

Potential Breaking Change:

This is passing all existing Protractor tests, but there is a
possibility that the changes to the control flow will cause some
test flows to hang. If this causes issues, please revisit your
use of functions affecting the control flow, such as
`flow.execute`.
  • Loading branch information
juliemr committed Sep 29, 2015
1 parent 673d416 commit 9a202ab
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/debugger/debuggerCommons.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports.attachDebugger = function(pid, opt_port) {
client.setBreakpoint({
type: 'scriptRegExp',
target: '.*executors\.js', //jshint ignore:line
line: 37
line: 40
}, function() {
process.send('ready');
client.reqContinue(function() {
Expand Down
2 changes: 1 addition & 1 deletion lib/driverProviders/direct.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ DirectDriverProvider.prototype.getNewDriver = function() {
}

var service = new chrome.ServiceBuilder(chromeDriverFile).build();
driver = chrome.createDriver(
driver = new chrome.Driver(
new webdriver.Capabilities(this.config_.capabilities), service);
break;
case 'firefox':
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
"author": "Julie Ralph <ju.ralph@gmail.com>",
"dependencies": {
"request": "~2.57.0",
"selenium-webdriver": "2.45.1",
"selenium-webdriver": "2.47.0",
"minijasminenode": "1.1.1",
"jasminewd": "1.1.0",
"jasminewd2": "0.0.5",
"jasminewd2": "0.0.6",
"jasmine": "2.3.2",
"saucelabs": "~1.0.1",
"glob": "~3.2",
Expand Down

0 comments on commit 9a202ab

Please sign in to comment.