Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
ng-repeat-start should not return extra null element
Browse files Browse the repository at this point in the history
  • Loading branch information
fengxx authored and sjelin committed Dec 9, 2014
1 parent 78880ae commit a877268
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/clientsidescripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ functions.findBindings = function(binding, exactMatch, using, rootSelector) {
}
}
}
return [rows[index]].concat(multiRows[index]);
var row = rows[index] || [], multiRow = multiRows[index] || [];
return [].concat(row, multiRow);
};

/**
Expand Down

3 comments on commit a877268

@juliemr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: commit message should be

fix(locators): ng-repeat-start no longer returns extra null element

@sjelin
Copy link
Contributor

@sjelin sjelin commented on a877268 Dec 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this. I can do some git magic and change the commit message still, but I'd have to do a forced push. Is it worth it?

@juliemr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, don't worry about it. Just noting here in case anyone takes a look and wonders.

Please sign in to comment.