fix(protractor): isPresent() should work with out of bounds errors (#…

…3108)
angular · Apr 11, 2016 · bd78dfc · bd78dfc
1 parent 6f3a02f
commit bd78dfc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/lib/element.js b/lib/element.js
@@ -243,10 +243,10 @@ ElementArrayFinder.prototype.get = function(index) {
         i = parentWebElements.length + i;
       }
       if (i < 0 || i >= parentWebElements.length) {
-        throw new Error('Index out of bound. Trying to access element at ' +
-            'index: ' + index + ', but there are only ' +
-            parentWebElements.length + ' elements that match locator ' +
-            self.locator_.toString());
+        throw new webdriver.error.NoSuchElementError('Index out of bound. ' +
+            'Trying to access element at index: ' + index + ', but there are ' +
+            'only ' + parentWebElements.length + ' elements that match ' +
+            'locator ' + self.locator_.toString());
       }
       return [parentWebElements[i]];
     });

diff --git a/spec/basic/elements_spec.js b/spec/basic/elements_spec.js
@@ -111,6 +111,13 @@ describe('ElementFinder', function() {
       });
   });
 
+  it('isPresent() should be friendly with out of bounds error', function () {
+    browser.get('index.html#/form');
+    var elementsNotPresent = element.all(by.id('notPresentElementID'));
+    expect(elementsNotPresent.first().isPresent()).toBe(false);
+    expect(elementsNotPresent.last().isPresent()).toBe(false);
+  });
+
   it('isPresent() should not raise error on chained finders', function() {
     browser.get('index.html#/form');
     var elmFinder = $('.nopenopenope').element(by.binding('greet'));