Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
fix(locators): fix by.repeater finding all rows for IE
Browse files Browse the repository at this point in the history
Previously, element.all(by.repeater('foo in foos')) would find non-element
nodes for ng-repeat-start elements, which could cause IEDriver to fall over
if the test tried to get text from those nodes.
  • Loading branch information
juliemr committed May 21, 2014
1 parent b01ea83 commit c8c85e0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/clientsidescripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ clientSideScripts.findBindings = function(binding, exactMatch, using) {
var elem = repeatElems[i];
while (elem.nodeType != 8 ||
elem.nodeValue.indexOf(repeater) == -1) {
rows.push(elem);
if (elem.nodeType == 1) {
rows.push(elem);
}
elem = elem.nextSibling;
}
}
Expand Down

0 comments on commit c8c85e0

Please sign in to comment.