Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
use node 8.11 for circle
Browse files Browse the repository at this point in the history
Travis does not allow to specify node version 8.11 or 8.11.4. It has
been reported to webdriver-manager that 8.12.0 was having issues.
  • Loading branch information
cnishina committed Nov 8, 2018
1 parent bb9507e commit f0ab327
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 12 deletions.
14 changes: 7 additions & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: node_js
sudo: false
node_js:
- "9"
- "8"
- "10"

env:
Expand All @@ -16,17 +16,17 @@ env:
matrix:
- JOB=full
- JOB=smoke
- JOB=bstack
# - JOB=bstack

matrix:
allow_failures:
- env: "JOB=smoke"
- env: "JOB=bstack"
# - env: "JOB=bstack"
exclude:
- env: JOB=smoke
node_js: "9"
- env: JOB=bstack
node_js: "9"
node_js: "8"
# - env: JOB=bstack
# node_js: "8"

addons:
apt:
Expand All @@ -49,4 +49,4 @@ script:
- ./scripts/test_on_travis.sh

after_script:
- ./scripts/print_logs.sh
- ./scripts/print_logs.sh
2 changes: 1 addition & 1 deletion circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: circleci/node:10.13-browsers
- image: circleci/node:8.11-browsers
environment:
# Fix issue with selenium-server in containers.
# See http://github.com/SeleniumHQ/docker-selenium/issues/87
Expand Down
5 changes: 4 additions & 1 deletion spec/ciBStackConf.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@ var env = require('./environment.js');
exports.config = {
browserstackUser: process.env.BROWSER_STACK_USERNAME,
browserstackKey: process.env.BROWSER_STACK_ACCESS_KEY,
SELENIUM_PROMISE_MANAGER: false,

framework: 'jasmine',

// Spec patterns are relative to this directory.
specs: [
'basic/*_spec.js'
// TODO(selenium4): revert back to 'basic/*_spec.js', for now just use lib_spec
// 'basic/*_spec.js'
'basic/lib_spec.js'
],

// Exclude patterns are relative to this directory.
Expand Down
1 change: 1 addition & 0 deletions spec/ciFullConf.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ var env = require('./environment.js');
exports.config = {
sauceUser: process.env.SAUCE_USERNAME,
sauceKey: process.env.SAUCE_ACCESS_KEY,
SELENIUM_PROMISE_MANAGER: false,

framework: 'jasmine',

Expand Down
9 changes: 6 additions & 3 deletions spec/ciSmokeConf.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,16 @@ var env = require('./environment.js');
exports.config = {
sauceUser: process.env.SAUCE_USERNAME,
sauceKey: process.env.SAUCE_ACCESS_KEY,
SELENIUM_PROMISE_MANAGER: false,

framework: 'jasmine',

specs: [
'basic/locators_spec.js',
'basic/mockmodule_spec.js',
'basic/synchronize_spec.js'
// TODO(selenium4): revert back. For now just put on lib_spec.js
// 'basic/locators_spec.js',
// 'basic/mockmodule_spec.js',
// 'basic/synchronize_spec.js'
'basic/lib_spec.js'
],

// Two latest versions of IE, and Safari.
Expand Down

0 comments on commit f0ab327

Please sign in to comment.