ElementFinder.prototype.then not returning a promise

[Ferengee]

I would expect every .then call to return a promise.
Since the protractor test below passes, ElementFinder's then method clearly returns the return value of the succes function.

When reading the documentation: https://github.com/angular/protractor/blob/master/docs/api.md#elementfinderprototypethen
I get the impression that it should return a promise (or a then-able)

Maybe this is a design decision, if so I would like to know the reason.
On a side note: I am very happy with protractor and I enjoy seeing the progress it makes. Thanks

Protractor test on version 1.0.0

describe('ElementFinder.then', function() {
  var fqdn = browser.params.fqdn;

  beforeEach(function(){
    browser.get('http://' + fqdn);
    browser.ignoreSynchronization = true;
  });  
it('should always return a promise', function(){
    var e1 = element(by.tagName("body")).then(function(){});
    expect(e1).toBeUndefined();
    //expect(typeof (e1.then)).toBe("function");

    var e1 = element(by.tagName("body"))
    .then(function(){return protractor.promise.fullyResolved({});});
    expect(e1).not.toBeUndefined();
    expect(typeof (e1.then)).toBe("function");
  });

});

[juliemr]

@hankduan we should probably wrap the returned function as an immediately-resolved promise. Can we do:

  ElementFinder.prototype.then = function(fn, errorFn) {
    if (this.opt_actionResult_) {
      return this.opt_actionResult_.then(fn, errorFn);
    } else {
      return webdriver.promise.fulfilled(fn(this)); // Change this line?
    }
  };

[hankduan]

fixed in #1158

[hankduan]

committed with d15d35a

[Ferengee]

Thanks for a very quick response