Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

A11y plugin improvements #1854

Closed
4 of 7 tasks
juliemr opened this issue Feb 25, 2015 · 7 comments
Closed
4 of 7 tasks

A11y plugin improvements #1854

juliemr opened this issue Feb 25, 2015 · 7 comments

Comments

@juliemr
Copy link
Member

juliemr commented Feb 25, 2015

  • pending Plugins: Add ability to hook in at the end of each test #1842 - audit after each test and merge results
  • Look into adding custom audits specific to Angular applications
  • Enable Tenon.io auditing for users of that service
  • Run the tests against Protractor's own website
  • Add an option to configure whether warnings from Chrome a11y are treated as pass or fail
  • Lower priority: Add meaningful duration numbers to test output
  • More sophisticated truncating of long element strings

@marcysutton did I miss anything?

@marcysutton
Copy link
Contributor

  • Missing accessibility/successConfig in test.js
  • Header identifying Chrome Accessibility Developer Tools in results

Question: will a11y plugin failures fail CI builds? Seems like part of #1842. I'm also curious what the output will look like when all the results are merged: will the accessibility Passes/Fails output separately for each page or all together at the end? I suppose we could identify elements by the page that triggered them if the results are merged together.

Added a little more info @juliemr. Thanks!

@juliemr
Copy link
Member Author

juliemr commented Feb 25, 2015

Yup, plugin failures will fail CI builds - they change the exit code to non-zero, which is all that Travis cares about.

For merging results, I think it's up to what we feel is most useful. We should probably use the test name to help developers pinpoint where failures actually occurred, but do some sort of deduplication if the same issue is present in a bunch of tests.

@marcysutton
Copy link
Contributor

I think I got the "identifying header" part solved by adding text to the Pass/Fail descriptions. It's especially useful when you run both integrations at the same time. PR coming shortly.

juliemr added a commit to juliemr/protractor that referenced this issue Mar 1, 2015
juliemr added a commit to juliemr/protractor that referenced this issue Mar 1, 2015
juliemr added a commit to juliemr/protractor that referenced this issue Mar 5, 2015
Instead of just printing the first N characters of the element's template,
print the first and last N/2.

See angular#1854
juliemr added a commit that referenced this issue Mar 9, 2015
Instead of just printing the first N characters of the element's template,
print the first and last N/2.

See #1854
@juliemr juliemr modified the milestone: Upcoming Mar 17, 2015
@marcysutton
Copy link
Contributor

Hey @juliemr I have another improvement to add to the accessibility plugin: make the output color configurable. The red and green colors are very hard to see for some folks.

@sjelin
Copy link
Contributor

sjelin commented Jul 7, 2015

There's a limited amount we can do with that. Most of the output comes from tools like jasmine.

@dylanb
Copy link

dylanb commented Aug 4, 2015

@juliemr I would like to integrate the axe-core https://github.com/dequelabs/axe-core ruleset into this functionality - WDYT?

@juliemr
Copy link
Member Author

juliemr commented Dec 22, 2016

Feature requests should now go to https://github.com/angular/protractor-accessibility-plugin

@juliemr juliemr closed this as completed Dec 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants