-
Notifications
You must be signed in to change notification settings - Fork 2.3k
A11y plugin improvements #1854
Comments
Question: will a11y plugin failures fail CI builds? Seems like part of #1842. I'm also curious what the output will look like when all the results are merged: will the accessibility Passes/Fails output separately for each page or all together at the end? I suppose we could identify elements by the page that triggered them if the results are merged together. Added a little more info @juliemr. Thanks! |
Yup, plugin failures will fail CI builds - they change the exit code to non-zero, which is all that Travis cares about. For merging results, I think it's up to what we feel is most useful. We should probably use the test name to help developers pinpoint where failures actually occurred, but do some sort of deduplication if the same issue is present in a bunch of tests. |
I think I got the "identifying header" part solved by adding text to the Pass/Fail descriptions. It's especially useful when you run both integrations at the same time. PR coming shortly. |
Instead of just printing the first N characters of the element's template, print the first and last N/2. See angular#1854
Instead of just printing the first N characters of the element's template, print the first and last N/2. See #1854
Hey @juliemr I have another improvement to add to the accessibility plugin: make the output color configurable. The red and green colors are very hard to see for some folks. |
There's a limited amount we can do with that. Most of the output comes from tools like jasmine. |
@juliemr I would like to integrate the axe-core https://github.com/dequelabs/axe-core ruleset into this functionality - WDYT? |
Feature requests should now go to https://github.com/angular/protractor-accessibility-plugin |
@marcysutton did I miss anything?
The text was updated successfully, but these errors were encountered: