-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Protractor 3.1.1 doesn't run test for application having .debugInfoEnalbled(false) #3009
Comments
It looks like that commit has the order wrong - Angular first checks if the string starts with NG_ENABLE_DEBUG_INFO, and then checks for the NG_DEFER_BOOTSTRAP string. Needs to be switched. |
Note that in most cases, this should not have surfaced as an issue because the base test mock modules will also try to turn on debug info. Closes angular#3009
closes angular#3035 Note that in most cases, this should not have surfaced as an issue because the base test mock modules will also try to turn on debug info. Closes angular#3009
Hi Guys, I'm using protractor 3.2.2 now and still not able to run my test WITHOUT hacking it with |
I'm rolling back the associated PR since it is causing issues with older versions of Angular. Note that if you are not using manual bootstrap, we should be able to turn on debug info by using Protractor's default set of mock modules. @ravitej-klair can you provide a test application that we can run against showing where this fails? |
I'm using Protratctor 3.2.2 and attempted to use elementExplorer. Here are the results of running various commands. For details on the setup, see this page: http://stackoverflow.com/questions/36851322/attempting-to-select-angular-component-element-and-getting-an-error?noredirect=1#comment61273847_36851322
|
I noticed that the status and type was changed. I'm not sure if you need something more reproducible, but if it helps, here's what I did. Run npm start which displayed the "My First Angular 2 App" text appropriately. See attached file for the result of This was performed on a MacOS (El Capitan 10.11.4). For the tutorial, I copied the text and pasted it in the files using Sublime Text (I decided to remove the IDE variable). $ npm ls --depth=0 |
OH this is for Angular2. Angular2 does not respond to the I'm not sure if that was the original issue from @ravitej-klair or not, but in either case, I'm closing this as infeasible to change for now. See instead clean new issue: #3174 |
Pretty new here,
Recently upgraded to Protractor 3.1.1 and testing the debug feature (148f020)
I understand that the debug flag added in the protractor.js helps to run the tests for applications with
.debugInfoEnabled(false);
But my test doesn't without the following hack
browser.executeScript('window.name = "NG_ENABLE_DEBUG_INFO!"');
But wasn't this the whole point of upgrading to Protractor 3.1.1 so you don't have to do this?!
Any suggestions?
The text was updated successfully, but these errors were encountered: