Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Local driverProvider should use the update-config.json for binaries #3782

Closed
cnishina opened this issue Dec 2, 2016 · 3 comments · Fixed by #3922
Closed

Local driverProvider should use the update-config.json for binaries #3782

cnishina opened this issue Dec 2, 2016 · 3 comments · Fixed by #3922
Assignees
@cnishina
Labels
hotlist: polish type: feature request
Milestone
5.0

Comments

@cnishina
Copy link
Member

cnishina commented Dec 2, 2016

The binaries downloaded from webdriver-manager should be referenced from update-config.json
@cnishina cnishina self-assigned this Dec 2, 2016
@cnishina
Copy link
Member Author

cnishina commented Dec 2, 2016

Quick note: this fix should be against the beta branch.

@cnishina cnishina added this to the 5.0 milestone Jan 3, 2017
cnishina added a commit to cnishina/protractor that referenced this issue Jan 3, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
b7bdf63 
…ig.json

closes angular#3782
@cnishina cnishina mentioned this issue Jan 3, 2017
Merged
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
0a72661 
…ig.json

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
42a3c44 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
ccd448b 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 5, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
570ceba 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
6fe60e2 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
a8b64d9 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
1c82d2a 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit to cnishina/protractor that referenced this issue Jan 6, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
e5a35e7 
…ig.json

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes angular#3782
cnishina added a commit that referenced this issue Jan 6, 2017
@cnishina
chore(local): if no local drivers provided in config, use update-conf…
574d5c2 
…ig.json (#3922)

- turn on all unit tests and update them to work
- direct driver provider unit test for browser error
- local driver provider unit test for browser error

closes #3782
@bobbai
Copy link

bobbai commented Apr 24, 2017

I think this is not appropriate. Or just specify the version in update-config.json, not with path.

@cnishina
Copy link
Member Author

cnishina commented Apr 24, 2017 •
edited
Loading

Response in stackoverflow for overriding usage of update-config.json for local driver providers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cnishina cnishina

Labels
hotlist: polish type: feature request
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

chore(local): if no local drivers provided in config, use update-config.json cnishina/protractor
4 participants
@cnishina @juliemr @sjelin @bobbai