getCurrentUrl() should wait for Angular before executing

[juliemr]

The expectation should be that the page settles down before getCurrentUrl() executes.

Temporary fix - instead of doing ptor.getCurrentUrl().then... do

ptor.waitForAngular();
ptor.getCurrentUrl();

[ranjanbhambroo]

@juliemr I tried the temporary fix its timing out.

[Douwe92]

same here

[Douwe92]

I used the ptor.sleep(5000); to let the page load before it trys and get the current url. It works for me now.

[ranjanbhambroo]

@Douwe92 I tried your suggestion... Didnt work for me

[Douwe92]

Can you show your code? @rj051286

[ranjanbhambroo]

@Douwe92
var util = require('util');
describe('Login', function() {
var ptor;
beforeEach(function() {
ptor = protractor.getInstance();
ptor.get('#/login');
},30000);

it('allows user to log in', function() {
    ptor.findElement(protractor.By.input('login')).sendKeys('username');
    ptor.findElement(protractor.By.input('password')).sendKeys('password');
    ptor.findElement(protractor.By.css('input.login-form-container-button')).click(); 
});  
it('check for the url', function() {
    ptor.sleep(10000);
    var expectedUrl = ptor.baseUrl + '/#/missioncontrol';     
    expect(ptor.getCurrentUrl()).toBe(expectedUrl);    
}, 30000);  

});

[stickel]

@rj051286 What is it timing out on? One thing I noticed is there's no expectation on the first test. Try combining the two it statements into one test and see if that fixes your timeout issue.

var util = require('util');
describe('Login', function() {
    var ptor;
    beforeEach(function() {
        ptor = protractor.getInstance();
        ptor.get('#/login');
    },30000);

    it('allows user to log in', function() {
        var expectedUrl = ptor.baseUrl + '/#/missioncontrol';
        ptor.findElement(protractor.By.input('login')).sendKeys('username');
        ptor.findElement(protractor.By.input('password')).sendKeys('password');
        ptor.findElement(protractor.By.css('input.login-form-container-button')).click(); 
        ptor.sleep(10000);
        expect(ptor.getCurrentUrl()).toBe(expectedUrl);    
    }, 30000);  
});

[apankov1]

@stickel, thank you. I was having similar issue #57 and changed my code similar to yours and everything is working now.

[stickel]

@apankov1 Glad it helped! Hopefully it works for the issue @rj051286 is having.

[ranjanbhambroo]

@stickel Got this error now

ScriptTimeoutError: Timed out waiting for async script result after 1ms
Command duration or timeout: 12 milliseconds
Build info: version: '2.35.0', revision: 'c916b9d', time: '2013-08-12 15:42:01'
System info: os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.8.4', java.version: '1.6.0_51'
Session ID: 09c833e0-1e91-454e-98e4-b0e9094359e9
Driver info: org.openqa.selenium.firefox.FirefoxDriver
Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=firefox, rotatable=false, locationContextEnabled=true, version=23.0.1, cssSelectorsEnabled=true, databaseEnabled=true, handlesAlerts=true, browserConnectionEnabled=true, nativeEvents=false, webStorageEnabled=true, applicationCacheEnabled=true, takesScreenshot=true}]
Stacktrace:
ScriptTimeoutError: Timed out waiting for async script result after 1ms
Command duration or timeout: 12 milliseconds
Build info: version: '2.35.0', revision: 'c916b9d', time: '2013-08-12 15:42:01'
System info: os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.8.4', java.version: '1.6.0_51'
Session ID: 09c833e0-1e91-454e-98e4-b0e9094359e9
Driver info: org.openqa.selenium.firefox.FirefoxDriver
Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=firefox, rotatable=false, locationContextEnabled=true, version=23.0.1, cssSelectorsEnabled=true, databaseEnabled=true, handlesAlerts=true, browserConnectionEnabled=true, nativeEvents=false, webStorageEnabled=true, applicationCacheEnabled=true, takesScreenshot=true}]
at new bot.Error (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:109:18)
at Object.bot.response.checkResponse (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/response.js:106:9)
at /Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:275:20
at /Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1178:15
at webdriver.promise.ControlFlow.runInNewFrame_ (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1438:20)
at notify (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:328:12)
at notifyAll (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:297:7)
at fulfill (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:402:7)
at /Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1305:10
at /Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1178:15
==== async task ====
WebDriver.executeScript()
at webdriver.WebDriver.schedule (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:266:15)
at webdriver.WebDriver.executeAsyncScript (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:506:15)
at Protractor.waitForAngular (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/lib/protractor.js:375:22)
at Protractor.findElement (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/lib/protractor.js:478:8)
at null. (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/tests/test/scenarios/login1.js:11:14)
at /Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/jasminewd/index.js:54:12
at webdriver.promise.ControlFlow.runInNewFrame_ (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1438:20)
at webdriver.promise.ControlFlow.runEventLoop_ (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1303:8)
at wrapper as _onTimeout
==== async task ====
at null. (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/jasminewd/index.js:53:12)
at null. (/Users/ranjanbhambroo/Documents/protractor_voloforce_tests/node_modules/protractor/node_modules/minijasminenode/lib/async-callback.js:45:37)
at Timer.listOnTimeout as ontimeout

[apankov1]

@stickel one more question if I may.

I moved Sign In part to beforeEach part and it is failing again. I don't think it's a good idea to put all checks under one it neither to login each time.

Now my code looks like this:

var util = require('util');

describe('SignIn Page', function() {
    var ptor;
    beforeEach(function() {
        ptor = protractor.getInstance();
        ptor.get('#/login/');
        ptor.findElement(protractor.By.css('input[name=email]')).sendKeys("login");
        ptor.findElement(protractor.By.css('input[name=password]')).sendKeys("password");
        ptor.findElement(protractor.By.css('button.green.large')).click();
        ptor.waitForAngular();
    }, 30000);


    it ('Check URL after Sign In', function(){
        var expectedURL = ptor.baseUrl + 'home';
        ptor.sleep(10000);
        expect(ptor.getCurrentUrl()).toBe(expectedURL);
    }, 30000);

});

And it is failing. If I move code back to it ('Check URL after Sign In', function(){ it will start working correct.

What do you think will be the best way to do it? I want to structure my code so that Iog in in beforeEach and then write different test.

Thanks

[stickel]

@apankov1 How is it failing? What's the error? One thing to try (I haven't tested this) would be putting ptor.waitForAngular() inside the it block instead of the beforeEach block.

Why do you want to log in before each test? After the first login the app will remember the state it was in after each test. For example, if you first test the log in form (and it's successful), the next test will happen on the logged in state (/home in your case). If you really want to log in before each test, you may have to log out after each test because all tests will be run in the same session.