This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Changes for upcoming Angular refactoring #1233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, locators used 'document' as the root for their search. After this change, they will use the root element provided in the config file - `config.rootElement`. This will make sure behavior is correct if there are multiple angular apps on one page, and also enables the getTestability path, because that requires a root element under an ng-app.
This will be necessary after Angular commit angular/angular.js#8430 It should be a noop (which adds one webdriver command) for versions of Angular before that one.
|
LGTM |
|
Closed as 41d8128 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes which will be necessary before angular/angular.js#8430