This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Modified protractor to support testing node-webkit by using string conca... #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncatenation vs url.resolve() when the baseUrl begins with file://
|
Automated CLA checker says: please sign CLA at https://developers.google.com/open-source/cla/individual Please make sure that the email associated with your PR is the same as the email you use to sign. |
|
CLA signature found, thank you! |
|
Looks reasonable. Merged as 830f511 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to create a pull request for #1266 in case there was a chance it would be accepted.
When using AngularJS in https://github.com/rogerwang/node-webkit, the browser uses
file://based urls.The
baseUrlin the protractor config is stripped when it begins withfile://because it is run throughurl.resolve.This commit simply concatenates
baseUrlanddestinationwhen thebaseUrlbegins withfile://, otherwise it joins the variables withurl.resolve()as normal.This is the only issue that prevents us from running tests with protractor in a node-webkit project.