Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix(ng-repeat): properly detect the end of an ng-repeat-start block #2368

Merged
merged 1 commit into from
Nov 9, 2015
Merged

fix(ng-repeat): properly detect the end of an ng-repeat-start block #2368

merged 1 commit into from
Nov 9, 2015

Conversation

sjelin
Copy link
Contributor

@sjelin sjelin commented Jul 22, 2015

This bug was introduced when by.exactRepeater was

Discovered while investigating issue #2365

@sjelin sjelin mentioned this pull request Jul 22, 2015
Closed
@hankduan
Copy link
Contributor

Can you describe what this is for?

@sjelin
Copy link
Contributor Author

sjelin commented Sep 28, 2015

Uh, a bug! I can't remember the exact error anymore. Basically, way back in 324f69d, I replaced all the attr.indexOf(repeater) != -1 checks with repeaterMatch(attr, repeater, exact), which is stricter if exact is on. Some some of those indexOf(..) != -1 checks shouldn't have been changed. This essentially reverts my change in the places where is it inappropriate.

@sjelin
fix(ng-repeat): properly detect the end of an ng-repeat-start block
7cba4ec 
This bug was introduced when by.exactRepeater was

Discovered while investigating issue angular#2365
@sjelin sjelin merged commit 7cba4ec into angular:master Nov 9, 2015
@sjelin sjelin deleted the iss2365 branch November 17, 2015 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@hankduan hankduan

Labels
cla: yes pr: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjelin @hankduan @googlebot