chore(exitCodes): adding exit code for browser connect errors #3133

cnishina · 2016-04-15T23:27:21Z

No description provided.

cnishina · 2016-04-16T03:47:15Z

Unit tests added for BrowserError for direct connect.

cnishina · 2016-04-18T21:06:54Z

depends on #3131

juliemr · 2016-04-18T23:00:49Z

spec/unit/driverProviders/direct_test.js

+var fs = require('fs');
+var BrowserError = require('../../../built/exitCodes').BrowserError;
+
+var removeSeleniumFolder = function() {


Instead of doing this, just use a config file that points at a different (and invalid) chromedriver location.

cnishina · 2016-04-19T18:48:35Z

Instead of using the selenium folder, creating a "chromedriver" file in the os.tmpdir() for my unit test.

juliemr · 2016-04-19T19:29:20Z

spec/unit/driverProviders/direct_test.js

+  describe('with selenium drivers', function() {
+    var chromedriver = '';
+    beforeEach(function() {
+      // add files to selenium folder


Why is it important that the file have the correct version? Aren't we just testing that if the file exists but isn't a proper driver, we get the right error code?

I think this should either just use a bogus file that we create (like os.tpdir() + '/foo/bar') or not specify chromeDriver in the config and let the driverProvider use its normal logic.

juliemr · 2016-06-10T23:14:53Z

lib/driverProviders/browserStack.ts

@@ -3,10 +3,11 @@
 * It is responsible for setting up the account object, tearing
 * it down, and setting up the driver correctly.
 */
-import * as request from 'request';
+import * as https from 'https';


Can this 'request' removal be split into its own PR?

juliemr · 2016-06-10T23:36:43Z

A couple clean-up comments.

* use the thrown error for stack traces instead of creating a new one * use inheritance over creating a new error * read in stacktrace with captureStackTrace * removed default error messages

juliemr · 2016-06-13T23:14:42Z

lib/ptor.ts

@@ -2,7 +2,11 @@ import {Browser, ElementHelper} from './browser';
 import {ProtractorBy} from './locators';


This looks like an unrelated change.

Yes, I need to stop sneaking these in. Will revert this file back.

juliemr · 2016-06-14T05:17:13Z

LGTM once that's done.

googlebot added the cla: yes label Apr 15, 2016

sjelin added the pr: needs tests label Apr 16, 2016

cnishina force-pushed the pr_exitCodes_directConnect branch 2 times, most recently from 8793992 to 2b528bd Compare April 16, 2016 03:45

cnishina added pr: needs review and removed pr: needs tests labels Apr 16, 2016

cnishina force-pushed the pr_exitCodes_directConnect branch 2 times, most recently from 213a1df to 8b49b8a Compare April 18, 2016 21:05

cnishina force-pushed the pr_exitCodes_directConnect branch from 8b49b8a to 993f216 Compare April 18, 2016 22:10

juliemr reviewed Apr 18, 2016
View reviewed changes

juliemr added the pr: needs cleanup label Apr 18, 2016

juliemr assigned cnishina Apr 18, 2016

cnishina force-pushed the pr_exitCodes_directConnect branch 2 times, most recently from 4dbd109 to 9def91e Compare April 19, 2016 18:41

cnishina removed the pr: needs cleanup label Apr 19, 2016

juliemr reviewed Apr 19, 2016
View reviewed changes

cnishina force-pushed the pr_exitCodes_directConnect branch from 9def91e to fe344a9 Compare April 20, 2016 17:23

cnishina removed the pr: needs review label Apr 20, 2016

cnishina force-pushed the pr_exitCodes_directConnect branch 5 times, most recently from 8ea25f0 to 602f500 Compare April 22, 2016 19:55

cnishina changed the title ~~chore(exitCodes): adding exit code for direct connect errors~~ chore(exitCodes): adding exit code for browser connect errors Apr 22, 2016

cnishina force-pushed the pr_exitCodes_directConnect branch from 602f500 to df2cb56 Compare April 22, 2016 19:57

cnishina added the pr: needs review label Apr 22, 2016

cnishina removed their assignment Apr 22, 2016

juliemr self-assigned this Apr 26, 2016

cnishina force-pushed the pr_exitCodes_directConnect branch from 7dc0546 to 0dc0b26 Compare May 17, 2016 20:40

cnishina mentioned this pull request May 31, 2016

chore: url of BrowserStack Session at end of test #3247

Merged

cnishina added 4 commits June 8, 2016 16:13

chore(exitCodes): adding exit code for browser connect errors

c7d3f05

chore(exitCodes): adding exit code for browserstack error

1b077ab

chore(request): removing request module in favor of node https

ef513f6

chore(exitCodes): browser error for debug with multiple capabilities

d340ab2

cnishina force-pushed the pr_exitCodes_directConnect branch from 0dc0b26 to d340ab2 Compare June 8, 2016 23:15

juliemr reviewed Jun 10, 2016
View reviewed changes

juliemr assigned cnishina Jun 10, 2016

juliemr added the pr: needs cleanup label Jun 10, 2016

cnishina added 2 commits June 13, 2016 11:16

chore(request): remove request module change

83b4d4a

chore(cleanup): clean up per comments

fe98c6d

* use the thrown error for stack traces instead of creating a new one * use inheritance over creating a new error * read in stacktrace with captureStackTrace * removed default error messages

cnishina force-pushed the pr_exitCodes_directConnect branch from d4c13bb to fe98c6d Compare June 13, 2016 20:38

cnishina removed the pr: needs cleanup label Jun 13, 2016

juliemr reviewed Jun 13, 2016
View reviewed changes

juliemr added pr: LGTM and removed pr: needs review labels Jun 14, 2016

cnishina added 2 commits June 14, 2016 11:07

fix(test): supress exit code for config parser thrown error

81fb263

chore(revert): revert ptor clean up...will submit as own PR

4b54ec8

cnishina merged commit 78f3c64 into angular:master Jun 14, 2016

cnishina deleted the pr_exitCodes_directConnect branch June 14, 2016 19:23

calendir mentioned this pull request Aug 25, 2016

Protractor v4 exits with code 199 when EC or Chai throw an error #3491

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(exitCodes): adding exit code for browser connect errors #3133

chore(exitCodes): adding exit code for browser connect errors #3133

cnishina commented Apr 15, 2016

cnishina commented Apr 16, 2016

cnishina commented Apr 18, 2016

juliemr Apr 18, 2016

cnishina commented Apr 19, 2016

juliemr Apr 19, 2016

juliemr Jun 10, 2016

cnishina Jun 13, 2016

juliemr commented Jun 10, 2016

juliemr Jun 13, 2016

cnishina Jun 14, 2016

juliemr commented Jun 14, 2016

		@@ -2,7 +2,11 @@ import {Browser, ElementHelper} from './browser';
		import {ProtractorBy} from './locators';

chore(exitCodes): adding exit code for browser connect errors #3133

chore(exitCodes): adding exit code for browser connect errors #3133

Conversation

cnishina commented Apr 15, 2016

cnishina commented Apr 16, 2016

cnishina commented Apr 18, 2016

juliemr Apr 18, 2016

Choose a reason for hiding this comment

cnishina commented Apr 19, 2016

juliemr Apr 19, 2016

Choose a reason for hiding this comment

juliemr Jun 10, 2016

Choose a reason for hiding this comment

cnishina Jun 13, 2016

Choose a reason for hiding this comment

juliemr commented Jun 10, 2016

juliemr Jun 13, 2016

Choose a reason for hiding this comment

cnishina Jun 14, 2016

Choose a reason for hiding this comment

juliemr commented Jun 14, 2016