-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix #3697 - Selenium 3.0.1 problem - wrong jvm params #3698
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
* if you need to change the browser driver, use | ||
* jvmArgs: ['-Dwebdriver.ie.driver=IEDriverServer_Win32_2.53.1.exe'] | ||
*/ | ||
jvmArgs?: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be jvmArgs?: string[];
@@ -580,6 +587,7 @@ export interface Config { | |||
ng12Hybrid?: boolean; | |||
|
|||
seleniumArgs?: Array<any>; | |||
jvmArgs?: Array<any>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be jvmArgs?: string[];
Please follow CONTRIBUTING.md commit message and squash your commit. Thanks. |
Made changes and closed with f3938f9 |
No description provided.