Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Fix #3697 - Selenium 3.0.1 problem - wrong jvm params #3698

Closed
wants to merge 5 commits into from
Closed

Fix #3697 - Selenium 3.0.1 problem - wrong jvm params #3698

wants to merge 5 commits into from

Conversation

sptq
Copy link
Contributor

@sptq sptq commented Nov 3, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sptq
Copy link
Contributor Author

sptq commented Nov 3, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

* if you need to change the browser driver, use
* jvmArgs: ['-Dwebdriver.ie.driver=IEDriverServer_Win32_2.53.1.exe']
*/
jvmArgs?: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be jvmArgs?: string[];

@@ -580,6 +587,7 @@ export interface Config {
ng12Hybrid?: boolean;

seleniumArgs?: Array<any>;
jvmArgs?: Array<any>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be jvmArgs?: string[];

@cnishina
Copy link
Member

cnishina commented Nov 7, 2016

Please follow CONTRIBUTING.md commit message and squash your commit. Thanks.

@cnishina
Copy link
Member

cnishina commented Nov 9, 2016

Made changes and closed with f3938f9

@cnishina cnishina closed this Nov 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants