Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

chore(types): fixed types to use selenium-webdriver #3851

Closed
wants to merge 2 commits into from

Conversation

stephenlautier
Copy link

@stephenlautier stephenlautier commented Dec 20, 2016

Currently when installed e.g. with Aurelia skeleton project (in my case) there are several errors thrown when building due to protractor.

ERROR in [at-loader] node_modules\protractor\built\browser.d.ts:260:37
    Cannot find namespace 'webdriver'.

ERROR in [at-loader] node_modules\protractor\built\browser.d.ts:267:55
    Cannot find namespace 'webdriver'.

ERROR in [at-loader] node_modules\protractor\built\browser.d.ts:267:78
    Cannot find namespace 'webdriver'.

ERROR in [at-loader] node_modules\protractor\built\browser.d.ts:358:31
    Cannot find namespace 'webdriver'.

ERROR in [at-loader] node_modules\protractor\built\browser.d.ts:369:26
    Cannot find namespace 'webdriver'.

ERROR in [at-loader] node_modules\protractor\built\browser.d.ts:425:36
    Cannot find namespace 'webdriver'.

ERROR in [at-loader] node_modules\protractor\built\ptor.d.ts:13:29
    Cannot find namespace 'webdriver'.

This should fix just that.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@jtheoof
Copy link

jtheoof commented Dec 20, 2016

I believe the latest commit should be style(browser): code formatting to respect angular commit convention. But other than that it looks good. It would be great to have it merged soon, it is breaking the build on our side as well. Thanks @stephenlautier for this !

@cnishina cnishina self-requested a review December 20, 2016 19:05
@cnishina cnishina self-assigned this Dec 20, 2016
@cnishina
Copy link
Contributor

Closing this PR since this has been resolved with #3848. The JSDoc changes does not fix the transpile errors. The errors were due to a DefinitelyTyped @types/selenium-webdriver release that changed the typings. We will have a hot fix later today. Thanks for the PR.

@cnishina cnishina closed this Dec 20, 2016
@stephenlautier
Copy link
Author

@cnishina i know the JSDocs doesnt fix the errors, that was extra since they were not pointing correctly. the fixes are for the actual params/return types. its good if its fixed else were👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants