Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

docs(developers): add basic DEVELOPER.md and update README #4026

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

juliemr
Copy link
Member

@juliemr juliemr commented Jan 27, 2017

No description provided.

@juliemr
Copy link
Member Author

juliemr commented Jan 27, 2017

@sjelin @cnishina @mgiambalvo all suggestions welcome!

Copy link
Contributor

@sjelin sjelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small additions I'd like to see in this PR


```
npm run format
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also run linting with $(npm bin)/gulp lint

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


`webdriver-js-extender` extends selenium-webdriver to add Appium commands.
github.com/angular/webdriver-js-extender

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no webdriver-manager?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh. Added.


Travis runs e2e tests via SauceLabs against a variety of browsers. The essential browsers run a
more complete test suite. We also run a set of smoke tests against a larger set of browsers,
which is allowed to fail. This is due to flakiness in IE, Safari and older browser versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call out the specific conf files here - ciFull, ciSmoke, etc. Also what's up with BrowserStack? Is that intended to work? It seems to flake slightly more often than Travis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

which is allowed to fail. This is due to flakiness in IE, Safari and older browser versions.

Circle CI runs a slightly modified version of `npm test` in a single VM. It installs
the browsers it needs locally. Circle CI runs unit tests and a set of e2e tests against Chrome.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention why we have two systems? Circle limits you by running instance time, so it's better to keep the Saucelabs tests running on Travis. Also, stdout and stderr logs of all processes as well as a tcpdump of webdriver traffic are all available in the CircleCI artifacts for each build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@sjelin sjelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants