Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix(restart): preserve properties like browser.baseUrl upon restart #4037

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

sjelin
Copy link
Contributor

@sjelin sjelin commented Jan 31, 2017

I also fixed a minor issue where internalRootEl wasn't being set when blocking proxy was being
used. I also just cleaned up our internal uses of this.rootEl.

Closes #4032

I also fixed a minor issue where `internalRootEl` wasn't being set when blocking proxy was being
used.  I also just cleaned up our internal uses of `this.rootEl`.

Closes angular#4032
@sjelin sjelin added this to the 5.1 milestone Jan 31, 2017
@sjelin sjelin requested a review from heathkit January 31, 2017 08:58
@sjelin sjelin merged commit 9c2274d into angular:master Jan 31, 2017
sjelin added a commit to sjelin/protractor that referenced this pull request Feb 1, 2017
Missed in angular#4037

Also fixed minor (so minor I think it was impossible to trigger) in initializing
plugins.
sjelin added a commit to sjelin/protractor that referenced this pull request Feb 1, 2017
Missed in angular#4037

Also fixed a minor error where the promises implicitly created by setting
`rootEl` and `ignoreSynchronization` weren't getting chained properly.

Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.
sjelin added a commit to sjelin/protractor that referenced this pull request Feb 1, 2017
…se chaining

Missed in angular#4037

Also fixed a minor error where the promises implicitly created by setting
`rootEl` and `ignoreSynchronization` weren't getting chained properly.

Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.
sjelin added a commit to sjelin/protractor that referenced this pull request Feb 1, 2017
…se chaining

I noticed I missed `waitForAngularEnabled` in
angular#4037.  This commit fixed that.

While I was at it I fixed a minor error where the promises implicitly created by
setting `rootEl` and `ignoreSynchronization` weren't getting chained properly.

Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.
cnishina pushed a commit that referenced this pull request Feb 1, 2017
…se chaining (#4047)

I noticed I missed `waitForAngularEnabled` in
#4037.  This commit fixed that.

While I was at it I fixed a minor error where the promises implicitly created by
setting `rootEl` and `ignoreSynchronization` weren't getting chained properly.

Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.
igniteram pushed a commit to igniteram/protractor that referenced this pull request Feb 21, 2017
…angular#4037)

I also fixed a minor issue where `internalRootEl` wasn't being set when blocking proxy was being
used.  I also just cleaned up our internal uses of `this.rootEl`.

Closes angular#4032
igniteram pushed a commit to igniteram/protractor that referenced this pull request Feb 21, 2017
…se chaining (angular#4047)

I noticed I missed `waitForAngularEnabled` in
angular#4037.  This commit fixed that.

While I was at it I fixed a minor error where the promises implicitly created by
setting `rootEl` and `ignoreSynchronization` weren't getting chained properly.

Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.
bodyduardU pushed a commit to bodyduardU/protractor that referenced this pull request Dec 5, 2022
…se chaining (#4047)

I noticed I missed `waitForAngularEnabled` in
angular/protractor#4037.  This commit fixed that.

While I was at it I fixed a minor error where the promises implicitly created by
setting `rootEl` and `ignoreSynchronization` weren't getting chained properly.

Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser.restart should copy over baseUrl and some other properties
3 participants