This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix(restart): preserve properties like browser.baseUrl upon restart
#4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also fixed a minor issue where `internalRootEl` wasn't being set when blocking proxy was being used. I also just cleaned up our internal uses of `this.rootEl`. Closes angular#4032
heathkit
approved these changes
Jan 31, 2017
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Feb 1, 2017
Missed in angular#4037 Also fixed minor (so minor I think it was impossible to trigger) in initializing plugins.
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Feb 1, 2017
Missed in angular#4037 Also fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Feb 1, 2017
…se chaining Missed in angular#4037 Also fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Feb 1, 2017
…se chaining I noticed I missed `waitForAngularEnabled` in angular#4037. This commit fixed that. While I was at it I fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
cnishina
pushed a commit
that referenced
this pull request
Feb 1, 2017
…se chaining (#4047) I noticed I missed `waitForAngularEnabled` in #4037. This commit fixed that. While I was at it I fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…angular#4037) I also fixed a minor issue where `internalRootEl` wasn't being set when blocking proxy was being used. I also just cleaned up our internal uses of `this.rootEl`. Closes angular#4032
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…se chaining (angular#4047) I noticed I missed `waitForAngularEnabled` in angular#4037. This commit fixed that. While I was at it I fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
bodyduardU
pushed a commit
to bodyduardU/protractor
that referenced
this pull request
Dec 5, 2022
…se chaining (#4047) I noticed I missed `waitForAngularEnabled` in angular/protractor#4037. This commit fixed that. While I was at it I fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed a minor issue where
internalRootElwasn't being set when blocking proxy was beingused. I also just cleaned up our internal uses of
this.rootEl.Closes #4032