This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(docs): Cleanup plugin docs #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heathkit
approved these changes
Feb 7, 2017
docs/plugins.md
Outdated
| ``` | ||
|
|
||
| Each of these exported properties are optional. | ||
| Plugins are node modules who's `module.exports` implement the `ProtractorPlugin` |
There was a problem hiding this comment.
maybe "Plugins are a node module that export an object implementing the ProtractorPlugin interface"?
heathkit
reviewed
Feb 7, 2017
lib/plugins.ts
Outdated
| @@ -188,40 +191,44 @@ export interface ProtractorPlugin { | |||
| * before executing the next command. This can be disabled using | |||
| * browser.ignoreSynchronization, but that will also disable any | |||
| * <Plugin>.waitForPromise or <Plugin>.waitForCondition checks. If you want | |||
| * to | |||
| * disable synchronization with angular, but leave in tact any custom plugin | |||
| * to disable synchronization with angular, but leave in tact any custom plugin | |||
* Removed redundent information in `/docs/plugins.md`. Now redirects to `/lib/plugins.ts`. * Comment cleanup in `/lib/plugins.ts` * Export some necessary types in `/lib/index.ts`
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
* Removed redundent information in `/docs/plugins.md`. Now redirects to `/lib/plugins.ts`. * Comment cleanup in `/lib/plugins.ts` * Export some necessary types in `/lib/index.ts`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/docs/plugins.md. Now redirects to/lib/plugins.ts./lib/plugins.ts/lib/index.ts