feat(driverProvider) Adding browserstackProxy param in BrowserStack driverProvider #4852
Conversation
raghuhit
changed the title
|
@qiyigg Can you please review this? |
|
@qiyigg |
| this.browserstackClient = BrowserstackClient.createAutomateClient({ | ||
| username: this.config_.browserstackUser, | ||
| password: this.config_.browserstackKey, | ||
| proxy: this.config_.browserstackProxy |
There was a problem hiding this comment.
If this.config_.browserstackProxy is not set, will it break this code? It would be better to have a test for it.
There was a problem hiding this comment.
I have added test for browserStack driverProvider's basic functionality check.
It will not break by this.
And tests are now failing in circleci with error "Error: does not exist in logs: WebDriverError: Sauce Labs Authentication Error." and in travis due to some reason. I think there is some issue with Sauce labs credentials, can you please check and review this PR.
|
@qiyigg , Any comments on this? And can you re run the travis and circleci builds, as travis build ran successfully, when I ran it under my account from my repo. |
|
Rebuilding.. |
|
@qiyigg I have fixed a minor issue in test cases in "scripts/errorTest.js" file with saucelabs' driver, after which the previously failing test in circleci is getting passed now but now the build is failing in circleci because it was not able to create GeckoDriverService, which is an intermittent issue and I don't think it has anything to do with code. |
|
merged, thanks |
|
Thank you :) |
Adding browserstackProxy configuration param to enable users behind proxy to run their tests, example value for this config : "http://proxy.example.com:1234".