-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore(test): move element_spec off of the control flow #4998
Conversation
* note that JSHint still does not support `async ... await` - jshint/jshint#2604 . It might be better to move to ESLint * add `try ... catch` * add `await` * I get flaky EPIPE errors for .filter(), .map(), .reduce() methods
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Thanks for this. I found some issues with my work. This was a great commit either way. If you want to help out, I'm going to work on:
and then I'll jump around to other tests in the suite. This means in the basic, I will not touch these files if you want to take a shot at them. Please work on one file at a time as a pull request.
Also a quick review of the PR submitted, it looks like you have a lot of trailing spaces on lines. If you are using visual studio code, there is a setting to remove trailing settings. (https://stackoverflow.com/questions/30884131/remove-trailing-spaces-automatically-or-with-a-shortcut) I'll also add this to the tracking issue. Thanks again! |
async ... await
- Support for async functions jshint/jshint#2604 . It might be better to move to ESLinttry ... catch
await
directConnect: true
async ... await