Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

chore(test): move handling_spec off of the control flow #5010

Merged
merged 1 commit into from
Nov 8, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions spec/basic/handling_spec.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@

describe('handling timeout errors', function() {

it('should call error handler on a timeout', function() {
browser.get('http://dummyUrl', 1).then(function() {
describe('handling timeout errors', () => {
it('should call error handler on a timeout', async () => {
try {
await browser.get('http://dummyUrl', 1);
throw 'did not handle error';
}, function(err) {
} catch (err) {
expect(err instanceof Error).toBeTruthy();
});
}
});
});
3 changes: 2 additions & 1 deletion spec/basicConf.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ exports.config = {
// Spec patterns are relative to this directory.
specs: [
'basic/elements_spec.js',
'basic/lib_spec.js'
'basic/lib_spec.js',
'basic/handling_spec.js'
],

// Exclude patterns are relative to this directory.
Expand Down
3 changes: 2 additions & 1 deletion spec/ciFullConf.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ exports.config = {
// TODO(selenium4): revert back to basic/*_spec.js
specs: [
'basic/elements_spec.js',
'basic/lib_spec.js'
'basic/lib_spec.js',
'basic/handling_spec.js'
],

// Exclude patterns are relative to this directory.
Expand Down