This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): move expected_conditions_spec off of the control flow #5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference #4995 |
|
The travis test failing is because of the ciNg2 test. I hope to have this resolved. It might require one more rebase. I'll keep you posted. |
cnishina
suggested changes
Nov 8, 2018
cnishina
approved these changes
Nov 9, 2018
|
Thank you for cleaning all those spaces up! |
|
Thank you for giving me possibility to contribute :) |
cnishina
pushed a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
cnishina
pushed a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cnishina , could you take a look at this PR, please