Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

move interactive_test_util off q, rework to ES6 syntax #5037

Merged
merged 5 commits into from
Nov 27, 2018
Merged

move interactive_test_util off q, rework to ES6 syntax #5037

merged 5 commits into from
Nov 27, 2018

Conversation

CrispusDH
Copy link
Contributor

  • move interactive_test_util off q, rework to ES6 syntax
  • interactive_test.js and with_base_url.js still does not work as expected. Maybe we should rework commands or it does not work correctly together with common executor.

@CrispusDH
Copy link
Contributor Author

@cnishina , @heathkit could you take a look at this PR, please

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

circle.yml Outdated
@@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: circleci/node:8.11-browsers
- image: circleci/node:10.13.0-browsers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change this back. We had a discussion about this and it should be 8.11 for now.

@cnishina cnishina added cla: yes and removed cla: no labels Nov 16, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@CrispusDH
Copy link
Contributor Author

@cnishina could you change label to yes and merge :)

@cnishina cnishina added cla: yes and removed cla: no labels Nov 17, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@CrispusDH
Copy link
Contributor Author

@cnishina should I make some additional changes?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@CrispusDH
Copy link
Contributor Author

@cnishina , I merge selenium4 branch into this one. Now it is up to date.

@cnishina cnishina added cla: yes and removed cla: no labels Nov 27, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@cnishina
Copy link
Member

Fixed the CLAs. This PR is great. I'm trying to remove q and this aligns well.

I also think I stabilized the Travis tests by updating the browser versions we use in Sauce Labs. If it doesn't pass, I'll restart it but I'm not concerned if it doesn't pass.

@cnishina cnishina merged commit 13a8668 into angular:selenium4 Nov 27, 2018
@CrispusDH CrispusDH deleted the interactive_test branch November 27, 2018 18:22
cnishina pushed a commit to cnishina/protractor that referenced this pull request Dec 19, 2018
angular#5037)

- move interactive_test_util off q
- rework to ES6 syntax
cnishina pushed a commit to cnishina/protractor that referenced this pull request Mar 23, 2019
angular#5037)

- move interactive_test_util off q
- rework to ES6 syntax
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants