-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TypeScript 2.3. #471
Conversation
@@ -43,7 +43,7 @@ | |||
"mocha": "^3.2.0", | |||
"temp": "^0.8.1", | |||
"tslint": "^3.15.1", | |||
"typescript": "2.2.1" | |||
"typescript": "2.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this file also references typescript
under "peerDependencies", but I wasn't sure if that should also be modified, since it wasn't changed when upgrading to 2.2 (it is currently set to ^2.1.0
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change both. The peerDependencies are only used from npm, not g3, which is why we didn't notice, but they should be the same value.
(And then run yarn again just to check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I removed the leading ^
, as it didn't make sense to make it different from the other version specifier.
Ran yarn, and nothing was modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run "yarn" once to update the yarn locks for this new TS version?
Done - ran |
The `.path` property of SourceFile has now been marked @internal, but it seems we can just use `.fileName` to the same effect.
Note that we might need to rollback the other change that you are CC'd on about the bug. |
The
.path
property of SourceFile has now been marked @internal, but itseems we can just use
.fileName
to the same effect.Note that before this is merged, we should create a ts22 branch in tsickle for future commits that need to target TS 2.2.