Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 2.3. #471

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Upgrade to TypeScript 2.3. #471

merged 1 commit into from
Apr 25, 2017

Conversation

voithos
Copy link
Contributor

@voithos voithos commented Apr 18, 2017

The .path property of SourceFile has now been marked @internal, but it
seems we can just use .fileName to the same effect.

Note that before this is merged, we should create a ts22 branch in tsickle for future commits that need to target TS 2.2.

@@ -43,7 +43,7 @@
"mocha": "^3.2.0",
"temp": "^0.8.1",
"tslint": "^3.15.1",
"typescript": "2.2.1"
"typescript": "2.3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this file also references typescript under "peerDependencies", but I wasn't sure if that should also be modified, since it wasn't changed when upgrading to 2.2 (it is currently set to ^2.1.0).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change both. The peerDependencies are only used from npm, not g3, which is why we didn't notice, but they should be the same value.

(And then run yarn again just to check)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I removed the leading ^, as it didn't make sense to make it different from the other version specifier.
Ran yarn, and nothing was modified.

Copy link
Contributor

@evmar evmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run "yarn" once to update the yarn locks for this new TS version?

@voithos
Copy link
Contributor Author

voithos commented Apr 18, 2017

Done - ran yarn and the TS version was updated in the lock file (It did re-format a bunch of other things in the lock file, though). I suppose we'll probably want to do this again later once TS 2.3.0 finalizes (it's currently RC)?

The `.path` property of SourceFile has now been marked @internal, but it
seems we can just use `.fileName` to the same effect.
@evmar
Copy link
Contributor

evmar commented Apr 25, 2017

Note that we might need to rollback the other change that you are CC'd on about the bug.

@evmar evmar merged commit f02ab3b into angular:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants