fix(language-server): Ensure LS is enabled in same order as project i… #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitialization ngcc processes might finish out of order, but we need to re-enable the language service for the projects in the same order that the ngcc processes were spawned in. With solution-style configs, we need to ensure that the language service enabling respects the order that the projects were defined in the references list. If we enable the language service out of order, the second project in the list will request diagnostics first and then be the project that's prioritized for that project's set of files. This will cause issues if the second project is, for example, one that only includes `*.spec.ts` files and not the entire set of files needed to compile the app (i.e. `*.module.ts`). A test was not written for this because it is difficult to consistently emulate the `ngcc` processes finishing out of order with solution style project configs. Fixes angular#1444
alxhub
approved these changes
Jul 13, 2021
zarend
approved these changes
Jul 13, 2021
atscott
added a commit
that referenced
this pull request
Jul 14, 2021
…nitialization (#1447) ngcc processes might finish out of order, but we need to re-enable the language service for the projects in the same order that the ngcc processes were spawned in. With solution-style configs, we need to ensure that the language service enabling respects the order that the projects were defined in the references list. If we enable the language service out of order, the second project in the list will request diagnostics first and then be the project that's prioritized for that project's set of files. This will cause issues if the second project is, for example, one that only includes `*.spec.ts` files and not the entire set of files needed to compile the app (i.e. `*.module.ts`). A test was not written for this because it is difficult to consistently emulate the `ngcc` processes finishing out of order with solution style project configs. Fixes #1444 (cherry picked from commit 1434226)
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nitialization
ngcc processes might finish out of order, but we need to re-enable the language service for
the projects in the same order that the ngcc processes were spawned in. With solution-style
configs, we need to ensure that the language service enabling respects the order that the
projects were defined in the references list. If we enable the language service out of order,
the second project in the list will request diagnostics first and then be the project that's
prioritized for that project's set of files. This will cause issues if the second project is,
for example, one that only includes
*.spec.tsfiles and not the entire set of files neededto compile the app (i.e.
*.module.ts).A test was not written for this because it is difficult to consistently emulate the
ngccprocesses finishing out of order with solution style project configs.Fixes #1444